suckless/slock
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

No need for usage()

Browse source 
There are 2 arguments why -v and -h are broken:

	1) if you are running off git, -v will show the last stable
           release, effectively making this option useless.
           people running stable versions leave open an attack surface
           this way in case there are vulnerabilities found.
           99% of the people are also using package managers to keep
           their software up to date, instead of running $TOOL -v to
           check how old it is.
        2) -h is a sad excuse for not just looking at the manual page
           (man 1 slock). Given we accept a post_lock_command, we can't
           be as liberal and just intercept certain flags.

I changed the manpage to reflect this change.
This commit is contained in:
FRIGN 2016-02-14 01:48:48 +01:00
parent bdcbeab0d8
commit a6dc051e37
2 changed files with 9 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

16
slock.c
View file

@ -272,27 +272,15 @@ lockscreen(Display *dpy, int screen)
return NULL;
}
static void
usage(void)
{
fprintf(stderr, "usage: slock [-v|POST_LOCK_CMD]\n");
exit(1);
}
int
main(int argc, char **argv) {
main(int argc, char **argv)
{
#ifndef HAVE_BSD_AUTH
const char *pws;
#endif
Display *dpy;
int screen;
if ((argc == 2) && !strcmp("-v", argv[1]))
die("slock-%s, © 2006-2016 slock engineers\n", VERSION);
if ((argc == 2) && !strcmp("-h", argv[1]))
usage();
#ifdef __linux__
dontkillme();
#endif