suckless/slock
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

end{pw,sp}ent() can only be called after get{pw,sp}ent()

Browse source 
Calling them unconditionally can result in memory corruption.
This commit is contained in:
sin 2014-11-07 13:20:13 +00:00
parent 8745098fa4
commit 4339b507af
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
slock.c
View file

@ -73,7 +73,6 @@ getpw(void) { /* only run as root */
else else
die("slock: cannot retrieve password entry (make sure to suid or sgid slock)\n"); die("slock: cannot retrieve password entry (make sure to suid or sgid slock)\n");
} }
endpwent();
rval = pw->pw_passwd; rval = pw->pw_passwd;
#if HAVE_SHADOW_H #if HAVE_SHADOW_H
@ -82,7 +81,6 @@ getpw(void) { /* only run as root */
sp = getspnam(getenv("USER")); sp = getspnam(getenv("USER"));
if(!sp) if(!sp)
die("slock: cannot retrieve shadow entry (make sure to suid or sgid slock)\n"); die("slock: cannot retrieve shadow entry (make sure to suid or sgid slock)\n");
endspent();
rval = sp->sp_pwdp; rval = sp->sp_pwdp;
} }
#endif #endif