actions/rs-toolchain
0
0
Fork 0
mirror of https://github.com/actions-rs/toolchain.git synced 2025-09-06 16:21:57 +03:00
Code Issues Projects Releases Packages Wiki Activity

Invert the priority order of the input and the rust-toolchain file

Browse source 
1. Not doing so would be a breaking change for users who have
a rust-toolchain file with a different version from what they
specify in the input.
2. Not doing so makes it overly complicated to install a specific
version.
Imagine you want to test your software against the version in the
rust-toolchain file and nightly as-well. Without this patch, users
will have the replace the content of the rust-toolchain file because
it is prioritized over the input.
It makes a lot more sense to prioritize the input over the file
because that one is easier changed.
This commit is contained in:
Thomas Eizinger 2020-01-14 10:16:10 +11:00
parent 9cf95ed753
commit 568a53bc9a
No known key found for this signature in database
GPG key ID: 651AC83A6C6C8B96
5 changed files with 38 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

1
action.yml
View file

@ -10,6 +10,7 @@ inputs:
Rust toolchain name.
See https://github.com/rust-lang/rustup.rs#toolchain-specification
required: false
target:
description: Target triple to install for this toolchain
required: false