mirror of
https://github.com/actions-rs/toolchain.git
synced 2025-09-06 16:21:57 +03:00
Invert the priority order of the input and the rust-toolchain file
1. Not doing so would be a breaking change for users who have a rust-toolchain file with a different version from what they specify in the input. 2. Not doing so makes it overly complicated to install a specific version. Imagine you want to test your software against the version in the rust-toolchain file and nightly as-well. Without this patch, users will have the replace the content of the rust-toolchain file because it is prioritized over the input. It makes a lot more sense to prioritize the input over the file because that one is easier changed.
This commit is contained in:
parent
9cf95ed753
commit
568a53bc9a
5 changed files with 38 additions and 14 deletions
|
@ -40,6 +40,16 @@ describe('actions-rs/toolchain', () => {
|
|||
'INPUT_TOOLCHAIN': 'nightly',
|
||||
});
|
||||
|
||||
expect(args.name).toBe("nightly")
|
||||
});
|
||||
|
||||
it('uses rust-toolchain file if input does not exist', function () {
|
||||
let rustToolchainFile = tempWriteSync("1.39.0");
|
||||
|
||||
let args = morph(() => {
|
||||
return toolchain_args(rustToolchainFile);
|
||||
}, {});
|
||||
|
||||
expect(args.name).toBe("1.39.0")
|
||||
});
|
||||
|
||||
|
@ -48,9 +58,7 @@ describe('actions-rs/toolchain', () => {
|
|||
|
||||
let args = morph(() => {
|
||||
return toolchain_args(rustToolchainFile);
|
||||
}, {
|
||||
'INPUT_TOOLCHAIN': 'nightly',
|
||||
});
|
||||
}, {});
|
||||
|
||||
expect(args.name).toBe("1.39.0")
|
||||
});
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue