From eeadd646e231d2f873d59b60a811ef4fe35ad483 Mon Sep 17 00:00:00 2001 From: crueter Date: Fri, 14 Nov 2025 23:17:27 -0500 Subject: [PATCH] prefer [] over test Signed-off-by: crueter --- forgejo-release.sh | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/forgejo-release.sh b/forgejo-release.sh index e3a096e..a4522fa 100755 --- a/forgejo-release.sh +++ b/forgejo-release.sh @@ -38,20 +38,21 @@ setup_tea() { } get_tag() { - if ! test -f "$TAG_FILE"; then + if [ -f "$TAG_FILE" ]; then if api GET "repos/$REPO/tags/$TAG_URL" >"$TAG_FILE"; then echo "tag $TAG exists" else echo "tag $TAG does not exist" fi fi - test -s "$TAG_FILE" + + [ -s "$TAG_FILE" ] } matched_tag() { if get_tag; then sha=$(jq --raw-output .commit.sha <"$TAG_FILE") - test "$sha" = "$SHA" + [ "$sha" = "$SHA" ] else return 1 fi @@ -132,7 +133,7 @@ maybe_use_release_note_assistant() { } sign_release() { - if test -s "$GPG_PASSPHRASE"; then + if [ -s "$GPG_PASSPHRASE" ]; then passphrase="--passphrase-file $GPG_PASSPHRASE" fi gpg --import --no-tty --pinentry-mode loopback "$passphrase" "$GPG_PRIVATE_KEY" @@ -146,13 +147,13 @@ sign_release() { } maybe_sign_release() { - if test -s "$GPG_PRIVATE_KEY"; then + if [ -s "$GPG_PRIVATE_KEY" ]; then sign_release fi } maybe_override() { - if test "$OVERRIDE" = "false"; then + if [ "$OVERRIDE" = "false" ]; then return fi api DELETE "repos/$REPO/releases/tags/$TAG_URL" > /dev/null 2>&1 || true @@ -206,7 +207,7 @@ wait_release() { ready=false for _ in $(seq "$RETRY"); do if api GET "repos/$REPO/releases/tags/$TAG_URL" | jq --raw-output .draft >"$TMP_DIR"/draft; then - if test "$(cat "$TMP_DIR"/draft)" = "false"; then + if [ "$(cat "$TMP_DIR"/draft)" = "false" ]; then ready=true break fi